chore: apply codacy fixes (#3935)

Co-authored-by: shortcuts <[email protected]>

.github/actions/setup/action.yml

@@ -106,7 +106,7 @@ runs:
       run: |
         curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.60.3
         echo "$(go env GOPATH)/bin" >> $GITHUB_PATH
-        go install golang.org/x/tools/cmd/goimports@latest
+        go install golang.org/x/tools/cmd/goimports@v0.22.0
 
     - name: Cache golangci-lint analysis
       if: ${{ inputs.language == 'go' }}

clients/algoliasearch-client-go/go.mod

@@ -1,6 +1,6 @@
 module github.com/algolia/algoliasearch-client-go/v4
 
-go 1.21
+go 1.21.11
 
 require github.com/go-playground/validator/v10 v10.22.1
 

clients/algoliasearch-client-javascript/packages/algoliasearch/__tests__/algoliasearch.browser.test.ts

@@ -1,4 +1,3 @@
-/* eslint no-console: 0 */
 import { expect, test, vi } from 'vitest';
 
 import { LogLevelEnum } from '../../client-common/src/types';

clients/algoliasearch-client-javascript/packages/algoliasearch/__tests__/algoliasearch.fetch.test.ts

@@ -1,4 +1,3 @@
-/* eslint no-console: 0 */
 import { expect, test, vi } from 'vitest';
 
 import { LogLevelEnum } from '../../client-common/src/types';

clients/algoliasearch-client-javascript/packages/algoliasearch/__tests__/algoliasearch.node.test.ts

@@ -1,4 +1,3 @@
-/* eslint no-console: 0 */
 import { expect, test, vi } from 'vitest';
 
 import { LogLevelEnum } from '../../client-common/src/types';

clients/algoliasearch-client-javascript/packages/algoliasearch/vitest.workspace.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line import/no-unresolved
 import { defineWorkspace } from 'vitest/config';
 
 export default defineWorkspace([

clients/algoliasearch-client-javascript/packages/client-common/src/__tests__/logger/null-logger.test.ts

@@ -1,4 +1,3 @@
-/* eslint no-console: 0 */
 import { describe, expect, test, vi } from 'vitest';
 
 import { createNullLogger } from '../../logger';

clients/algoliasearch-client-javascript/packages/client-common/vitest.workspace.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line import/no-unresolved
 import { defineWorkspace } from 'vitest/config';
 
 export default defineWorkspace([

clients/algoliasearch-client-javascript/packages/logger-console/src/__tests__/logger-console.test.ts

@@ -1,4 +1,3 @@
-/* eslint no-console: 0 */
 import { beforeEach, describe, expect, test, vi } from 'vitest';
 
 import { LogLevelEnum } from '@algolia/client-common';

clients/algoliasearch-client-javascript/packages/logger-console/src/logger.ts

@@ -1,4 +1,3 @@
-/* eslint no-console: 0 */
 import type { LogLevelType, Logger } from '@algolia/client-common';
 import { LogLevelEnum } from '@algolia/client-common';
 

clients/algoliasearch-client-javascript/packages/logger-console/vitest.workspace.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line import/no-unresolved
 import { defineWorkspace } from 'vitest/config';
 
 export default defineWorkspace([

clients/algoliasearch-client-javascript/packages/requester-browser-xhr/vitest.config.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line import/no-unresolved
 import { defineConfig } from 'vitest/config';
 
 export default defineConfig({

clients/algoliasearch-client-javascript/packages/requester-fetch/src/__tests__/fetch-requester.test.ts

@@ -82,7 +82,6 @@ describe('status code handling', () => {
     const data = Buffer.from('äöü');
 
     // create a test response stream that is chunked inside a unicode character
-    // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
     function* generate() {
       yield data.subarray(0, 3);
       yield data.subarray(3);

clients/algoliasearch-client-javascript/packages/requester-fetch/vitest.config.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line import/no-unresolved
 import { defineConfig } from 'vitest/config';
 
 export default defineConfig({

clients/algoliasearch-client-javascript/packages/requester-node-http/src/__tests__/node-http-requester.test.ts

@@ -138,7 +138,6 @@ describe('status code handling', () => {
     const data = Buffer.from('äöü');
 
     // create a test response stream that is chunked inside a unicode character
-    // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
     function* generate() {
       yield data.subarray(0, 3);
       yield data.subarray(3);

clients/algoliasearch-client-javascript/packages/requester-node-http/src/createHttpRequester.ts

@@ -31,7 +31,6 @@ export function createHttpRequester({
   function send(request: EndRequest): Promise<Response> {
     return new Promise((resolve) => {
       let responseTimeout: NodeJS.Timeout | undefined;
-      // eslint-disable-next-line prefer-const -- linter thinks this is not reassigned
       let connectTimeout: NodeJS.Timeout | undefined;
       const url = new URL(request.url);
       const path = url.search === null ? url.pathname : `${url.pathname}${url.search}`;

clients/algoliasearch-client-javascript/packages/requester-node-http/vitest.config.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line import/no-unresolved
 import { defineConfig } from 'vitest/config';
 
 export default defineConfig({