Skip to content
This repository has been archived by the owner on May 9, 2019. It is now read-only.

Commit

Permalink
fix: decode HTML entities before sending them to Algolia (#768)
Browse files Browse the repository at this point in the history
This commit will decode HTML entities for the post content attribute before sending it to Algolia.
This ensures we do not end up displaying things like `&`.

This issue arises now because we properly escape the content in the frontend directly.

The solution is to store the decoded HTML in Algolia and let the frontend handle the escaping.

In order to benefit from this fix, you should re-index everything.

You can also choose to cherry pick and  update the posts having an encoded char displayed.

**Test plan:**

The fix has manually been tested by adding `&` in the post editor.
This would turn the symbol into `&` but stores it as `&` in Algolia.

To be sure, I also tried to inject JS directly from adding script tags to an Algolia record.
They are properly escaped at run time.

Closes: #656
  • Loading branch information
rayrutjes authored Jul 2, 2018
1 parent d80ffe6 commit cfa0b23
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion includes/class-algolia-utils.php
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ public static function remove_content_noise( $content ) {
$content = preg_replace( $pattern, '', $content );
}

return $content;
return html_entity_decode( $content );
}

/**
Expand Down

0 comments on commit cfa0b23

Please sign in to comment.