Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI errors to do with Nokogiri::HTML4 #440

Open
bagedevimo opened this issue Nov 15, 2023 · 0 comments
Open

Fix CI errors to do with Nokogiri::HTML4 #440

bagedevimo opened this issue Nov 15, 2023 · 0 comments

Comments

@bagedevimo
Copy link
Contributor

When submitting MRs, I notice we have some flakey specs. These are (probably) due to a rubygem cache on the circleCI runners using an older version of loofah which doesn't have the fixes introduced in 2.12.2 [1].

https://github.com/flavorjones/loofah/blob/main/CHANGELOG.md#2212--2023-05-11

There are a few options to solve this, the simplest is to wipe the CI caches in CircleCI which should force it to resolve new gems, and install the fixed version of Loofah. Another solution would be to check Gemfile.lock into source control, which might have other issues but would mean you can prescribe the version of loofah used in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant