Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): add banners in renderingContent #1522

Merged
merged 1 commit into from
May 7, 2024

Conversation

aymeric-giraudet
Copy link
Member

These are types for the upcoming no-code Banner feature.

taylorcjohnson
taylorcjohnson previously approved these changes Apr 17, 2024
Copy link

@taylorcjohnson taylorcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since the failing tests don't appear to be related.

shortcuts
shortcuts previously approved these changes Apr 17, 2024
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, could you please reflect it in https://github.com/algolia/api-clients-automation/blob/b621988bce6f17f53bc12cc04d2f852d79b3cfee/specs/common/schemas/IndexSettings.yml#L983?

for the CI, it's super flaky so... you'll have to re-run it a bunch of times :(

@aymeric-giraudet
Copy link
Member Author

@shortcuts doesn't the Swagger spec file get generated itself too ?
If not we may do it manually but it should be done by those owning the backend code

@shortcuts
Copy link
Member

shortcuts commented Apr 24, 2024

@shortcuts doesn't the Swagger spec file get generated itself too ? If not we may do it manually but it should be done by those owning the backend code

no the spec is the entrypoint that generates everything, it needs manual edits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants