-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(types): add banners
in renderingContent
#1522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving since the failing tests don't appear to be related.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, could you please reflect it in https://github.com/algolia/api-clients-automation/blob/b621988bce6f17f53bc12cc04d2f852d79b3cfee/specs/common/schemas/IndexSettings.yml#L983?
for the CI, it's super flaky so... you'll have to re-run it a bunch of times :(
0d59473
435f1f8
to
0d59473
Compare
@shortcuts doesn't the Swagger spec file get generated itself too ? |
no the spec is the entrypoint that generates everything, it needs manual edits |
These are types for the upcoming no-code Banner feature.