Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

# fix(types): updating reRankingApplyFilter type and adding new property to RankingInfo #1394

Merged
merged 2 commits into from
Feb 23, 2022

Conversation

alphonseb
Copy link

@alphonseb alphonseb commented Feb 22, 2022

fix(types): updating reRankingApplyFilter type and adding new property to RankingInfo

This is a follow up to #1378

What

  1. Adding null to the list of possible types for the reRankingApplyFilter search/setting option
  2. Adding property promotedByReRanking to the RankingInfo type.

Why

  1. This is how we reset the filter in the dashboard, it was an oversight in the first PR.
  2. Has been sent back by the engine for some time but was never added to the client's types.

@alphonseb alphonseb self-assigned this Feb 22, 2022
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 22, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 50209ca:

Sandbox Source
algolia/create-instantsearch-app Configuration

@alphonseb alphonseb changed the title fix(types): updating reRankingApplyFilter type # fix(types): updating reRankingApplyFilter type and adding new property to RankingInfo Feb 22, 2022
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been added to the api client spec?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants