fix(node): reuse http agent across client #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
reviewed
Oct 19, 2020
| @@ -12,14 +12,17 @@ export type NodeHttpRequesterOptions = { | |||
| httpsAgent?: https.Agent; | |||
| }; | |||
|
|
|||
| const agentOptions = { keepAlive: true }; | |||
There was a problem hiding this comment.
this can be done inline now, I think it makes more sense
There was a problem hiding this comment.
well, it's just to be sure both agent are in sync, don't you think it's less error prone like that?
Haroenv
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1215
When you create multiple clients, wether by mistake or needed if you index to multiple app, http agents are recreated by default. That means they do not share the TCP pool and will race for TCP connection, even if they are the same.
If they do not share same domains, at least it still reduce the cost of maintaining multiple TCP pool.
Reusing the Agent allow to:
ENOTFOUNDEAI_AGAIN(Those errors are the most common ones that triggers the infamous "Unreachable hosts")