This repository has been archived by the owner on Jan 31, 2022. It is now read-only.
feat(clickAnalytics): Add clickAnalytics feature #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmogos
force-pushed
the
feat/clickAnalytics
branch
2 times, most recently
from
881b17c to
b31f14a
Compare
…queryID for analytics
robertmogos
force-pushed
the
feat/clickAnalytics
branch
from
b31f14a to
fe76c49
Compare
robertmogos
changed the title
q-litzler
approved these changes
Jun 19, 2018
PLNech
reviewed
Jun 20, 2018
| * @param enabled If set to true, the results will return queryID which is needed for sending click | conversion events. Defaults to false. | ||
| */ | ||
| public @NonNull | ||
| Query setClickAnalytics(Boolean enabled) { |
There was a problem hiding this comment.
Why not boolean (unnecessary boxing)?
There was a problem hiding this comment.
We've been inconsistent across Query on this, worth a refactoring to harmonize
There was a problem hiding this comment.
Added a task in asana to make it consistent around the client
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used to return the queryID