Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIDI pedal finished product release & LED color issue #330

Closed
bobvc133 opened this issue Apr 26, 2022 · 8 comments
Closed

MIDI pedal finished product release & LED color issue #330

bobvc133 opened this issue Apr 26, 2022 · 8 comments

Comments

@bobvc133
Copy link

This is my pedal! The latest sponsored version firmware has a problem with the LED color setting, it is set to red, but the actual display is green.
QQ截图20220426205906
QQ截图20220426205858
QQ截图20220426205914
QQ截图20220426205749
QQ截图20220426205813
QQ截图20220426210155

@mknerr
Copy link

mknerr commented Apr 26, 2022

That's beautiful!
Regarding your LED issue, I can't say for certain, but having worked with pixel strip before, I know the colors are not always addressed in the same order (ie., GRB, RGB, etc.), so you probably just need to tweak the code somewhere to adjust that.
If you try to make them Red, do they turn green?
@alf45tar, Perhaps an option could be added to the settings to make it easier to adjust. Probably not a big deal; you'd really only need to do this once.

@bobvc133
Copy link
Author

Yes, if you often need to modify the code to customize the settings, then it is meaningless to update the firmware through the browser, backup and restore the configuration file and other regular operations. Ordinary users basically cannot upgrade the firmware unless the firmware is a customized version. It is recommended to add custom settings such as the number of LEDs, vertically flip the screen, etc. to the WEB interface.

@mknerr
Copy link

mknerr commented Apr 26, 2022

Yeah, good point.

@alf45tar
Copy link
Owner

@bobvc133 it is amazing

@alf45tar
Copy link
Owner

That's beautiful!
Regarding your LED issue, I can't say for certain, but having worked with pixel strip before, I know the colors are not always addressed in the same order (ie., GRB, RGB, etc.), so you probably just need to tweak the code somewhere to adjust that.
If you try to make them Red, do they turn green?
@alf45tar, Perhaps an option could be added to the settings to make it easier to adjust. Probably not a big deal; you'd really only need to do this once.

Did you try to change the following setting?

#define LED_RGB_ORDER RGB // can be RGB or GRB

@bobvc133
Copy link
Author

That's beautiful!
Regarding your LED issue, I can't say for certain, but having worked with pixel strip before, I know the colors are not always addressed in the same order (ie., GRB, RGB, etc.), so you probably just need to tweak the code somewhere to adjust that.
If you try to make them Red, do they turn green?
@alf45tar, Perhaps an option could be added to the settings to make it easier to adjust. Probably not a big deal; you'd really only need to do this once.

Did you try to change the following setting?

#define LED_RGB_ORDER RGB // can be RGB or GRB

You can customize the settings by modifying the code, but I have to re-flash the machine. It is basically impossible to update the firmware through the browser. VS and PlatformIO sometimes have more problems. I hope that these custom items can be set in the WEB interface, and the flashing machine is simple. Just upgrade the firmware

@alf45tar
Copy link
Owner

Thanks @bobvc133 for the suggestion. I will try to add as much as possible every configuration parameters in the web interface with the next major release.
Another planned improvement is to remove use of EEPROM and use only configuration files to avoid problem on version upgrade.

@bobvc133
Copy link
Author

Thanks @bobvc133 for the suggestion. I will try to add as much as possible every configuration parameters in the web interface with the next major release. Another planned improvement is to remove use of EEPROM and use only configuration files to avoid problem on version upgrade.

Looking forward to the new version of the firmware, thank you for your efforts!

@bobvc133 bobvc133 closed this as completed Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants