Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map Elastiknn Exception types to the appropriate HTTP status codes #312

Open
alexklibisz opened this issue Sep 27, 2021 · 0 comments
Open
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@alexklibisz
Copy link
Owner

Describe the bug

Elastiknn exceptions do not extend ElasticsearchException, so they seem to always be turned into a 500, when a 4xx would often be more appropriate.

Expected behavior

(There are probably some other places where this is the case)

Environment (please complete the following information):

  • Elastiknn version: All
  • OS: All

To Reproduce

  • Attempt to run a query that is incompatible with a given mapping.
  • Attempt to index a vector of the wrong dimensionality.

Additional context

@alexklibisz alexklibisz added bug Something isn't working good first issue Good for newcomers labels Sep 27, 2021
@alexklibisz alexklibisz changed the title Exception types used by Elastiknn do not always map to the appropriate HTTP status codes Map Elastiknn Exception types to the appropriate HTTP status codes Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant