Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image version tagging #326

Closed
eltionb opened this issue Jan 13, 2023 · 7 comments
Closed

Docker image version tagging #326

eltionb opened this issue Jan 13, 2023 · 7 comments

Comments

@eltionb
Copy link

eltionb commented Jan 13, 2023

Instead of only using latest tag, can you also tag the image with the release version?

Example: ghcr.io/alexjustesen/speedtest-tracker:v0.11.0

@alexdelprete
Copy link
Contributor

@eltionb
Copy link
Author

eltionb commented Jan 13, 2023

Thanks for quick reply.
I actually based my issue on tags not showing up in docker hub: https://hub.docker.com/r/ajustesen/speedtest-tracker/tags

Just validated that tags are ok in ghcr.

great project btw

@alexjustesen
Copy link
Owner

it's already like this: https://github.com/alexjustesen/speedtest-tracker/tags

Yeah they're right, noticed this last night while on DH. This should def be addressed. @UnAfraid in the past you've helped with getting the Docker workflow polished, any chance you'd be able to help here too?

@UnAfraid
Copy link
Contributor

it's already like this: https://github.com/alexjustesen/speedtest-tracker/tags

Yeah they're right, noticed this last night while on DH. This should def be addressed. @UnAfraid in the past you've helped with getting the Docker workflow polished, any chance you'd be able to help here too?

Sure thing, i'll open up a PR soon.

@alexdelprete
Copy link
Contributor

Just validated that tags are ok in ghcr.

sorry, I tend not to use docker hub when possible, ghcr.io is much better, so I never tested it on DH. :)

@alexdelprete
Copy link
Contributor

Sure thing, i'll open up a PR soon.

The power of open-source and the spirit of collaboration never ceases to surprise me, even after all these years. Thank you guys. :)

@alexjustesen
Copy link
Owner

Sure thing, i'll open up a PR soon.

Really appreciate it, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants