Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High values are not shown on download latency chart 📊. #1825

Closed
gorucci opened this issue Nov 25, 2024 · 2 comments · Fixed by #1827
Closed

High values are not shown on download latency chart 📊. #1825

gorucci opened this issue Nov 25, 2024 · 2 comments · Fixed by #1827
Assignees
Labels
🐛 bug Something isn't working

Comments

@gorucci
Copy link

gorucci commented Nov 25, 2024

Describe the bug
High values are not shown on download latency chart. Some of my test results have high (pardon the repetition) "high download latency". To be specific, the 2 that are missing on a graph are 1006ms and 1102ms. This makes chart discontinuous.

To Reproduce
Steps to reproduce the behavior:

  1. Somehow get a result with more than 1000ms (not sure for the exact value) high download latency.
  2. Go to /admin aka Dashboard.
  3. Scroll down to "Download Latency" chart.
  4. See error.

Expected behavior
A clear and concise description of what you expected to happen.

Environment (please complete the following information):

  • OS: linuxserver/speedtest-tracker:0.23.1 container inside an ubuntu-server 24.04.
  • Architecture: amd64
  • Browser: macOS safari, iOS safari, macOS chrome, Windows chrome
  • Version 0.23.1

Screenshots
image

Logs
Results have no error messages.

Additional context
None.

@gorucci
Copy link
Author

gorucci commented Nov 25, 2024

Wow! That was crazy fast! Like, you know, off the charts fast (pun intended). Thank you.

TBH, I've tried to find a bug myself, like searching for the 1000 constant or analysing RecentDownloadLatencyChartWidget. But my lack of experience in PHP made this too tough 🥲. I had hope that your charts were made with some kind of JS lib. 

@alexjustesen
Copy link
Owner

number_format() function is what got us because it added a comma to the int which made it a string which the charts didn't like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants