Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional data to the Webhooks Payload #1580

Closed
hansenc0705 opened this issue Jun 27, 2024 · 9 comments
Closed

Add additional data to the Webhooks Payload #1580

hansenc0705 opened this issue Jun 27, 2024 · 9 comments
Labels
🎉 feature New feature or request

Comments

@hansenc0705
Copy link

Is your feature request related to a problem? Please describe.
Would it be possible to add more to the webhook notification?

Describe the solution you'd like
Add more of the speedtest data to the payload. Adding the SpeedTest.net Results URL to the Webhook might be enough but it would be nice to collect the same data that the table contains in the webhook payload

Additional context
Nothing additional besides a thank you.

@hansenc0705
Copy link
Author

I use SpeedTest Tracker to track my Starlink speeds, there is another site out there that is community maintained that tracks this data. trying to figure out the easiest way to get the data from SpeedTest Tracker over to starlinktrack.com

https://starlinktrack.com/speedtests/

@svenvg93
Copy link
Contributor

Adding only the Speedtest.net result URL is of course possible, but it will show the mostly the same data as that the payload already does. Is there any data you are looking for specificly?

The resutls table can show (almost) everything that is returned by the Speedtest CLI. Having all data in the payload might be a bit to much 😅 . Especially has all the notifications are using the same structure for the message. And my geuss is most people.

@hansenc0705
Copy link
Author

adding just the speedtest url is good for this idea to integrate into starlinktrack.com.

adding more data to the payload would just give people the ability to pull mort types of data out as needed but without knowing how everything works i dont know the level of effort or how it impacts other notifications.

@svenvg93
Copy link
Contributor

adding just the speedtest url is good for this idea to integrate into starlinktrack.com.

I will look into adding it

adding more data to the payload would just give people the ability to pull mort types of data out as needed but without knowing how everything works i dont know the level of effort or how it impacts other notifications.

I agree it also defeats the purpose of have a small notification if all the information is in there.

@hansenc0705
Copy link
Author

Well I think about it like some of the other products I worked with that have webhooks. You parse the data you need and ignore what you don't.

Thanks for looking at it @svenvg93, appreciate it.

@alexjustesen alexjustesen added the 🎉 feature New feature or request label Jun 28, 2024
@svenvg93
Copy link
Contributor

@alexjustesen FYI I will do this after the open PRs for 0.21.0 are merge into it. So I can do it for all at the same time.

@AliMickey
Copy link

Just jumping in to add the reason why I (starlinktrack.com) accept the speedtest result URL only:

  1. This allows me to check if the speedtest was actually run on Starlink,
  2. I pull the speedtest data directly from the trusted source, accepting raw data isn’t ideal as it can be spoofed.

Thanks for looking into adding this, as it will benefit the community of both of these apps :).

@eden22ltd
Copy link

would also like the url added to the webhook payload. useful to push all results to a google sheet for data manipulation and show the url for each test alongside

@svenvg93
Copy link
Contributor

svenvg93 commented Aug 5, 2024

@alexjustesen This one can be closed as the url is added in the merge with #1615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 feature New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants