Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualisation of failed speed tests #143

Closed
JKusber opened this issue Nov 11, 2022 · 6 comments · Fixed by #318
Closed

Visualisation of failed speed tests #143

JKusber opened this issue Nov 11, 2022 · 6 comments · Fixed by #318
Assignees
Labels
🎉 feature New feature or request
Milestone

Comments

@JKusber
Copy link

JKusber commented Nov 11, 2022

Describe the bug
My speedtest is scheduled every hour at :55. Today I had problems with my internet provider, my connection was first slower and then completely collapsed. Of course I wanted to have a look at that in the dashboard.

I noticed that failed speed tests (those during the interruption of the connection) are not displayed at all. If you look at several tests in the table, you might not even notice the leap in time (see screenshot). The tests in between are simply missing.

To Reproduce
Steps to reproduce the behavior:
Not sure if it is possible to repoduce it when you stop your network connection and have no idea how to simulate a provider malfunction.

Expected behavior
I would expect the failed tests to be displayed with a warning sign in the table and no speed/server. This way you could also evaluate how many tests failed.

Screenshots
If applicable, add screenshots to help explain your problem.

image

@alexjustesen
Copy link
Owner

I like this, absolutely a good suggestion and something that should be introduced.

@alexjustesen alexjustesen added the 🎉 feature New feature or request label Nov 11, 2022
@alexdelprete
Copy link
Contributor

I thought we already had something like that (with debug on for now):

image

@JKusber
Copy link
Author

JKusber commented Nov 11, 2022

I thought we already had something like that (with debug on for now):

image

Not sure how to activate this?! In my version I can't find this feature.
But anyway I would suggest to combine it in into one results list.

Thank you for the great project!

@alexjustesen
Copy link
Owner

Failed jobs are different from failed speedtests and should only be used for debugging purposes. Jobs are the Speedtest Tracker trying to do something.

If the speedtest-cli fails I don't currently capture and report that.

@alexdelprete
Copy link
Contributor

alexdelprete commented Nov 12, 2022

so jobs=internal tasks. got it. :) (btw: I opened an issue on those...)

definitely, we need to capture failed speedtests, I didn't know that was missing.

@alexjustesen
Copy link
Owner

Finally getting to this, you can follow the progress in #318. It's really more work than I had initially thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants