feat: remove any querystring from imports #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Just wondering why |
|
I didn't think that much about it, I just did what the webpack resolver do 😁 |
This was referenced Mar 11, 2021
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vite supports querystrings in imports like for instance:
import svg from "./image.svg?raw"(imports the file contents as a string).Such an import gets wrongly marked as unresolved by the rule
import/no-unresolvewhen using this resolver.The webpack resolver strips querystrings so that
import/no-unresolvecorrectly can resolve those imports.This PR adds the same feature to
eslint-import-resolver-typescript.