Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove .tsbuildinfo and d.ts.map files from package #57

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

gcangussu
Copy link
Contributor

I was doing a script to remove all .tsbuildinfo files from my monorepo and noted that this package is distributing those files. I got something like this:

$ find . -name '*.tsbuildinfo'
./node_modules/eslint-import-resolver-typescript/lib/tsconfig.tsbuildinfo
./packages/A/dist/tsconfig.tsbuildinfo
./packages/B/dist/tsconfig.tsbuildinfo
./packages/C/dist/tsconfig.tsbuildinfo

I think those files shouldn't be distributed, so I've filtered them out of the package. I've also left out .d.ts.map files, as they are unusable without the original sources, which are not distributed on the package.

I don't think we should stop generating .tsbuildinfo and .d.ts.map files, as they are useful for build performance and development experience. We should just not distribute them.

@JounQin
Copy link
Collaborator

JounQin commented Sep 29, 2020

Nice catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants