Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: import with .js and .jsx file extensions #56

Merged
merged 3 commits into from
Sep 1, 2020

Conversation

gcangussu
Copy link
Contributor

fixes #55

@JounQin
Copy link
Collaborator

JounQin commented Sep 1, 2020

Thanks! I would say it's a good feature instead of a bug fix.

@JounQin JounQin self-requested a review September 1, 2020 02:21
src/index.ts Outdated Show resolved Hide resolved
@gcangussu gcangussu changed the title fix: import with .js and .jsx file extension feat: import with .js and .jsx file extensions Sep 1, 2020
@gcangussu
Copy link
Contributor Author

Thanks! I would say it's a good feature instead of a bug fix.

Sure. I've renamed the PR to reflect that. Let me know if I should squash all commits and amend the commit message on my branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fails when importing with .js/.jsx extensions
2 participants