Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The container name should be configurable #51

Closed
dacrome opened this issue Apr 28, 2015 · 7 comments
Closed

The container name should be configurable #51

dacrome opened this issue Apr 28, 2015 · 7 comments

Comments

@dacrome
Copy link
Contributor

dacrome commented Apr 28, 2015

Use case: When you have multiple maven profiles to build a differently configured image it should be possible to start the containers side by side ... or because of problems with the circleci build because the tests run against a mysql and postgres database container ;)

[INFO] Image IDs do not match, removing container and creating new one from image
.
.
[ERROR] Failed to execute goal com.alexecollins.docker:docker-maven-plugin:2.8.2-SNAPSHOT:start
(start-docker-container) on project integration-tests:
com.github.dockerjava.api.InternalServerErrorException: Cannot destroy container 
6a639524d2b0506bd7e966891a0d55d6f7ce49091482040569f71d9beab1313a: 
Driver btrfs failed to remove root filesystem 
6a639524d2b0506bd7e966891a0d55d6f7ce49091482040569f71d9beab1313a: 
Failed to destroy btrfs snapshot: operation not permitted -> [Help 1]

I know this is more an issue of circleci but it would be a nice feature anyway and of course a workaround for the circleci limitation...

@alexec
Copy link
Owner

alexec commented Apr 28, 2015

Try setting <permissionErrorTolerant>true</permissionErrorTolerant> in your pom.xml?

@dacrome
Copy link
Contributor Author

dacrome commented Apr 28, 2015

yes, that fixed my issue on circleci! I already set it to true but didn't test it again... Anyway, do you think to make the container name configurable is a common use case?

@alexec
Copy link
Owner

alexec commented Apr 28, 2015

Have you tried setting the tag?

@dacrome
Copy link
Contributor Author

dacrome commented Apr 28, 2015

yes, the tag has no influence on the container name. Repo.java#L91

@alexec
Copy link
Owner

alexec commented Apr 28, 2015

Ok. I see what your getting at. Should be easy to update Conf.java to provide an optional container name. Maybe something like:

container:
   name: myName

Fancy being an awesome OSS contributor?

@alexec
Copy link
Owner

alexec commented Apr 29, 2015

Ok. Please try latest SNAPSHOT.

@dacrome
Copy link
Contributor Author

dacrome commented Apr 29, 2015

Nice, that was fast! Thanks!

@dacrome dacrome closed this as completed Apr 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants