diff --git a/e2e/ts_library/WORKSPACE b/e2e/ts_library/WORKSPACE index e7dbd98f75..7ea6c07525 100644 --- a/e2e/ts_library/WORKSPACE +++ b/e2e/ts_library/WORKSPACE @@ -46,9 +46,3 @@ install_bazel_dependencies() load("@npm_bazel_typescript//:index.bzl", "ts_setup_workspace") ts_setup_workspace() - -# Tell Bazel where the nested local repositories are that are used for tests -local_repository( - name = "disable_tsetse_for_external_test", - path = "disable_tsetse_for_external", -) diff --git a/e2e/ts_library/disable_tsetse_for_external/BUILD.bazel b/e2e/ts_library/disable_tsetse_for_external/BUILD.bazel deleted file mode 100644 index 9715f16cfe..0000000000 --- a/e2e/ts_library/disable_tsetse_for_external/BUILD.bazel +++ /dev/null @@ -1,23 +0,0 @@ -# Copyright 2017 The Bazel Authors. All rights reserved. -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -load("@npm_bazel_typescript//:index.bzl", "ts_library") - -package(default_visibility = ["//visibility:public"]) - -ts_library( - name = "main", - srcs = glob(["*.ts"]), - deps = ["@npm//@types"], -) diff --git a/e2e/ts_library/disable_tsetse_for_external/WORKSPACE b/e2e/ts_library/disable_tsetse_for_external/WORKSPACE deleted file mode 100644 index 96c1bacf63..0000000000 --- a/e2e/ts_library/disable_tsetse_for_external/WORKSPACE +++ /dev/null @@ -1,15 +0,0 @@ -# Copyright 2017 The Bazel Authors. All rights reserved. -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -workspace(name = "disable_tsetse_for_external_test") diff --git a/e2e/ts_library/disable_tsetse_for_external/main.ts b/e2e/ts_library/disable_tsetse_for_external/main.ts deleted file mode 100644 index 691f11af3d..0000000000 --- a/e2e/ts_library/disable_tsetse_for_external/main.ts +++ /dev/null @@ -1,19 +0,0 @@ -export {}; - -// string.trim() result is unused -let stringUnused; -stringUnused = 'hello'; -stringUnused.trim(); -const stringLiteralUnused = 'hello'; -stringLiteralUnused.trim(); - -// Array.concat() result is unused. -const arrayOfStringsUnused = ['hello']; -arrayOfStringsUnused.concat(arrayOfStringsUnused); - -// Object.create() result is unused -const objectUnused = {}; -Object.create(objectUnused); - -// string.replace() with a substring -stringUnused.replace('o', 'O'); diff --git a/e2e/ts_library/disable_tsetse_for_external/tsconfig.json b/e2e/ts_library/disable_tsetse_for_external/tsconfig.json deleted file mode 100644 index e69de29bb2..0000000000 diff --git a/e2e/ts_library/package.json b/e2e/ts_library/package.json index f526e095ee..54480be0fe 100644 --- a/e2e/ts_library/package.json +++ b/e2e/ts_library/package.json @@ -12,6 +12,6 @@ }, "scripts": { "pretest": "bazel run @nodejs//:yarn", - "test": "bazel build ... && bazel test ... && bazel build @disable_tsetse_for_external_test//..." + "test": "bazel test ..." } } diff --git a/packages/typescript/internal/build_defs.bzl b/packages/typescript/internal/build_defs.bzl index c998685926..0de58c4951 100644 --- a/packages/typescript/internal/build_defs.bzl +++ b/packages/typescript/internal/build_defs.bzl @@ -246,22 +246,6 @@ def tsc_wrapped_tsconfig( if jsx_factory: config["compilerOptions"]["jsxFactory"] = jsx_factory - tsetse_disabled_rules = [] - - # Matches section in javascript/typescript/tsconfig.bzl - # TODO(alexeagle): make them share code - if ctx.label.workspace_root.startswith("external/"): - # Violated by rxjs - tsetse_disabled_rules += ["ban-promise-as-condition"] - - # For local testing - tsetse_disabled_rules += ["check-return-value"] - - config["compilerOptions"]["plugins"] = [{ - "name": "@bazel/tsetse", - "disabledRules": tsetse_disabled_rules, - }] - return config # ************ #