fix(typescript): remove override of @bazel/tsetse

...in generated ts_library tsconfig. This fixes an issue where the @bazel/tsetse plugin values in a user's config would always be overridden by ts_library and not honoured. Also remove disable_tsetse_for_external test as we no longer doing this.

e2e/ts_library/WORKSPACE

@@ -46,9 +46,3 @@ install_bazel_dependencies()
 load("@npm_bazel_typescript//:index.bzl", "ts_setup_workspace")
 
 ts_setup_workspace()
-
-# Tell Bazel where the nested local repositories are that are used for tests
-local_repository(
-    name = "disable_tsetse_for_external_test",
-    path = "disable_tsetse_for_external",
-)

e2e/ts_library/package.json

@@ -12,6 +12,6 @@
   },
   "scripts": {
     "pretest": "bazel run @nodejs//:yarn",
-    "test": "bazel build ... && bazel test ... && bazel build @disable_tsetse_for_external_test//..."
+    "test": "bazel test ..."
   }
 }

packages/typescript/internal/build_defs.bzl

@@ -246,22 +246,6 @@ def tsc_wrapped_tsconfig(
     if jsx_factory:
         config["compilerOptions"]["jsxFactory"] = jsx_factory
 
-    tsetse_disabled_rules = []
-
-    # Matches section in javascript/typescript/tsconfig.bzl
-    # TODO(alexeagle): make them share code
-    if ctx.label.workspace_root.startswith("external/"):
-        # Violated by rxjs
-        tsetse_disabled_rules += ["ban-promise-as-condition"]
-
-        # For local testing
-        tsetse_disabled_rules += ["check-return-value"]
-
-    config["compilerOptions"]["plugins"] = [{
-        "name": "@bazel/tsetse",
-        "disabledRules": tsetse_disabled_rules,
-    }]
-
     return config
 
 # ************ #