Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks like 0.5.7 has broken things #16

Closed
primal100 opened this issue Jun 3, 2021 · 5 comments
Closed

Looks like 0.5.7 has broken things #16

primal100 opened this issue Jun 3, 2021 · 5 comments

Comments

@primal100
Copy link

Tested with python 3.8 and Python3.9. Works ok on aiopath 0.5.6

async for path in AsyncPath('.').glob():
    print(path)
TypeError: func_to_async_func() takes 1 positional argument but 2 were given
await f.read_text()
    async with self.open('r', encoding=encoding, errors=errors) as file:
AttributeError: __aexit__
@bronsen
Copy link

bronsen commented Jun 4, 2021

Can confirm.

Also this (from my CI):

>     async with self.open('r', encoding=encoding, errors=errors) as file:
E     AttributeError: __aenter__

Downgrading aiopath to 0.5.6 shows no such errors.

@lopisan
Copy link

lopisan commented Jun 11, 2021

Same for me - 0.5.7 is broken, 0.5.6 works. Same error as @bronsen

@alexdelorenzo
Copy link
Owner

alexdelorenzo commented Jul 7, 2021

Thanks for submitting bug reports, @primal100, @bronsen and @lopisan. Sorry for breaking aiopath on you!

I've added new tests here so that this doesn't happen again.

Version 0.5.11 on PyPI will fix your issues. You can install it like so:

python3 -m pip install aiopath==0.5.11

@bronsen
Copy link

bronsen commented Jul 7, 2021

Indeed aiopath 0.5.11 no longer raises the AttributeError during CI run.

@alexdelorenzo
Copy link
Owner

Glad to hear it, @bronsen.

I'm going to close this issue, feel free to comment again if anyone is still affected by this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants