Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer ownership of the name "xz" and "xz-sys" #64

Open
simnalamburt opened this issue Aug 8, 2020 · 8 comments
Open

Transfer ownership of the name "xz" and "xz-sys" #64

simnalamburt opened this issue Aug 8, 2020 · 8 comments

Comments

@simnalamburt
Copy link

Hi @alexcrichton! I'm Hyeon Kim, programmer from South Korea.

5 years ago, I created xz and xz-sys crate. Or more precisely, I just allocated the names and forgot updating. At the time, Rust didn't have LLVM bindings at all. I tried to make my own bindings as needed, but because I ran out of time, I completed only xz-sys part and stopped working on xz to do something more urgent.

And five years passed, completely forgetting that I stopped working on xz. Today I looked up the LLVM bindings again as needed, and found that packages named xz2 and llvm-sys were created.

It's a shame that what I forgot has confused people. There were people who were confused about which of the two libraries to use.

Transfer ownership of the "xz" crate and rename this library to xz seems to be a good way in many ways. What do you think?

@alexcrichton
Copy link
Owner

Seems reasonable to me! I don't really have much time to handle renaming right now, but it might be possible to make xz depend on xz2, flag itself as deprecated, and guide folks towards xz2 as a name? Perhaps one day I can get around to renaming things?

@simnalamburt
Copy link
Author

@alexcrichton I think it's a good idea. For the time being, let's do it that way, and rename it later if we get some time.

@alexcrichton
Copy link
Owner

@simnalamburt do you want to add me to the xz/xz-sys names? Or were you going to publish such a crate?

@simnalamburt
Copy link
Author

@alexcrichton I were going to publish a such crate but I didn't yet, but I just invited you to the xz and xz-sys crates thought 👍

image

If you're busy, we can work slowly and I'll help you, so please don't feel any pressure :)

@simnalamburt
Copy link
Author

simnalamburt commented Aug 17, 2020

I've just

  1. Invited you to xz and xz-sys crates
  2. Relicensed xz and xz-sys crates as (APACHE-2.0 OR MIT) license
  3. Aliased xz as xz2 and, xz-sys as lzma-sys with pub use xz2::* statement. You can check the results in https://docs.rs/xz and https://docs.rs/xz-sys

I also didn't forget to mention that "xz and xz-sys is currently an alias of xz2 and lzma-sys"

image

image

So maybe we can postpone the renaming thing little bit until we can handle it?

@alexcrichton
Copy link
Owner

Looks good to me! The only thing I'd add is a #[deprecated] tag to encourage use of xz2 instead of xz (to avoid having two ways to do the same thing)

@simnalamburt
Copy link
Author

If we're going to merge xz2 and xz into xz, isn't deprecating xz will confuse the future users more?

@alexcrichton
Copy link
Owner

Ok, I don't have time to work on this now, so this seems fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants