Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #114 Invalid memory reference with Filter::ia64 #6

Merged
merged 2 commits into from
Sep 24, 2023
Merged

Fix #114 Invalid memory reference with Filter::ia64 #6

merged 2 commits into from
Sep 24, 2023

Conversation

ChanTsune
Copy link

@ChanTsune ChanTsune commented Sep 24, 2023

Resolved segmentation fault reported in issue #114

As for adding -D HAVE_DECODER_IA64=1 -D HAVE_ENCODER_IA64=1 added to the issue, another problem remains, there is a lack of macros to declare the use of encoders corresponding to each Filter That's the reason.
Filters::arm requires -D HAVE_DECODER_ARM=1 -D HAVE_ENCODER_ARM=1 and Filters::arm_thumb requires -D HAVE_DECODER_ARMTHUMB=1 -D HAVE_ENCODER_ARMTHUMB=1

fix alexcrichton#114

@ChanTsune ChanTsune merged commit 027115b into Portable-Network-Archive:main Sep 24, 2023
12 checks passed
@ChanTsune ChanTsune deleted the fix/issue-114 branch September 24, 2023 03:33
@ChanTsune ChanTsune changed the title lzma-sys: Add #define macro HAVE_DECODER_IA64, `HAVE_ENCODER_IA64… Fix #114 Invalid memory reference with Filter::ia64 Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid memory reference with filter on some archs
1 participant