This repository has been archived by the owner on Sep 24, 2022. It is now read-only.
Fix disallowing duplicate table headers #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes #279 where a case of duplicate table headers slipped through the cracks. This also adds an option to disable this new validation to allow Cargo to preserve backwards compatibility.
|
r? @ehuss |
|
Nice! I like the workspace, too, was wondering why that hadn't been done earlier. |
alexcrichton
added a commit
to alexcrichton/cargo
that referenced
this pull request
Mar 18, 2019
The 0.5.0 release contained a [bugfix](toml-rs/toml-rs#280) which previously successfully parsed invalid TOML files, so we'll need to manually handle that in Cago to ensure that we don't accidentally regress crates, but rather instead give them an appropriate amount of time to get fixed.
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Mar 19, 2019
Handle backcompat hazard with `toml` crate The 0.5.0 release contained a [bugfix](toml-rs/toml-rs#280) which previously successfully parsed invalid TOML files, so we'll need to manually handle that in Cago to ensure that we don't accidentally regress crates, but rather instead give them an appropriate amount of time to get fixed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #279 where a case of duplicate table headers slipped
through the cracks. This also adds an option to disable this new
validation to allow Cargo to preserve backwards compatibility.