Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marks 3rd party test library as private dependency #166

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Marks 3rd party test library as private dependency #166

merged 1 commit into from
Oct 3, 2019

Conversation

aaronbrethorst
Copy link
Contributor

@aaronbrethorst aaronbrethorst commented Sep 6, 2019

This change means that consumers of the BulletinBoard library using Carthage will no longer have to take the snapshot test case library as a direct dependency of their own project when using BulletinBoard. The snapshot test case library will still be available to library developers as normal. carthage update, carthage bootstrap, etc. will all still work without change.

More information here: https://github.com/Carthage/Carthage/blob/master/Documentation/Artifacts.md

Checklist

Motivation and Context

My project uses Bulletin Board, and it is meant to be consumed by other projects as a framework. I don't want to make my users dependent on the snapshot test case library used in this project. By moving the dependency into the Cartfile.private file, this problem is solved.

This change means that consumers of the BulletinBoard library using Carthage will no longer have to take the snapshot test case library as a direct dependency of their own project when using BulletinBoard. The snapshot test case library will still be available to library developers as normal. carthage update, carthage bootstrap, etc. will all still work without change.

More information here: https://github.com/Carthage/Carthage/blob/master/Documentation/Artifacts.md
@alexisakers
Copy link
Owner

This is super thoughtful, thanks! Do I need to do anything for the change to be taken into account (making a new release?)

@aaronbrethorst
Copy link
Contributor Author

For my project, I'm currently using my fork aaronbrethorst/BulletinBoard with the private-deps branch. I'm happy to keep using it for the time being, so don't worry about creating a new release for the time being. The next time you make a release, the change should cascade down to all Carthage users automatically.

@aaronbrethorst
Copy link
Contributor Author

Sorry, to actually answer your question: for this change to be made available to Carthage users, you will need to publish a new release. Technically, I think this may constitute a breaking change if people are using the implicit dependency on the snapshot test case library to pull it in to their own projects, so it may be worth holding back from a release for the time being.

@alexisakers alexisakers merged commit d7354e7 into alexisakers:master Oct 3, 2019
ghost pushed a commit to mobisecitalia/BulletinBoard that referenced this pull request Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants