Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jansi to 2.4.1 #106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Friendseeker
Copy link

@Friendseeker
Copy link
Author

Friendseeker commented Nov 9, 2024

Btw since the change involve native code, want to be more careful than usual.

What procedures should we perform to ensure nothing goes wrong from this PR? I had checked

private static final List<String> JNI_CLASS_NAMES = Arrays.asList(
"org.fusesource.jansi.internal.CLibrary",
"org.fusesource.jansi.internal.CLibrary$WinSize",
"org.fusesource.jansi.internal.CLibrary$Termios",
"org.fusesource.jansi.internal.Kernel32",
"org.fusesource.jansi.internal.Kernel32$SMALL_RECT",
"org.fusesource.jansi.internal.Kernel32$COORD",
"org.fusesource.jansi.internal.Kernel32$CONSOLE_SCREEN_BUFFER_INFO",
"org.fusesource.jansi.internal.Kernel32$CHAR_INFO",
"org.fusesource.jansi.internal.Kernel32$KEY_EVENT_RECORD",
"org.fusesource.jansi.internal.Kernel32$MOUSE_EVENT_RECORD",
"org.fusesource.jansi.internal.Kernel32$WINDOW_BUFFER_SIZE_RECORD",
"org.fusesource.jansi.internal.Kernel32$FOCUS_EVENT_RECORD",
"org.fusesource.jansi.internal.Kernel32$MENU_EVENT_RECORD",
"org.fusesource.jansi.internal.Kernel32$INPUT_RECORD");

And Jansi 2.4.1 still has the same set of classes, does that mean we don't need to change NativeImageFeature?

Also I saw recent Jansi build includes a jni-config.json, does that mean we can remove NativeImageFeature or do we still need to keep it?

https://github.com/fusesource/jansi/blob/012fdaa2efdb1bd11bc2a4b30736f958e1fa0482/pom.xml#L247

(introduced in fusesource/jansi@8bafdf7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coursier.jar fails to run on Windows Arm64
1 participant