compliment is unable to find completions for a namespace that is aliased as user

[dpsutton]

Had a bug report in #cider on clojure slack.

If you have a namespace that you require with an alias as user there will be no completions found. The bug is from

(defn resolve-namespace
  "Tries to resolve a namespace from the given symbol, either from a
  fully qualified name or an alias in the given namespace."
  [sym ns]
  (or (find-ns sym) ((ns-aliases ns) sym)))

as the prefix 'user comes in and this resolves to the single segment namespace user.

Note this happens on the special single-segment ns user but could happen on anything that is single segment ns and has the same name as an alias.

The fix seems easy in that the aliases should be consulted first and then single segment namespaces after. This works because if the person has imported something as user, this is what they would prefer. And would seem to make referring to the single segment namespace impossible so the completions should mimic.

[alexander-yakushev]

Makes perfect sense. Thanks for the fix!

[wusticality]

Thanks for the fix @dpsutton, that was driving me nuts! :)