-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate returning false and friends in favor of promises #134
Comments
@dblock do we still want to support callbacks as well or can we purely support promises? This will also apply to pre/post. |
I think a deprecation message should happen first, then a major version bump and only supporting promises with good documentation is 👍 for me. |
Do we want to have a separate issue for actually implementing the changes and keep this simply for adding a deprecation message and updating the documentation? |
We want to have some pull requests :) |
Can this issue be closed? |
The change in #133 was backwards compatible, but we may want a major version change that supports only promises and just using:
We can also remove the
return false
functionality and make either returning a Promise or calling the callback required in order to send the response (or just call response.send() explicitly).The text was updated successfully, but these errors were encountered: