Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate returning false and friends in favor of promises #134

Closed
dblock opened this issue Jan 27, 2017 · 7 comments
Closed

Deprecate returning false and friends in favor of promises #134

dblock opened this issue Jan 27, 2017 · 7 comments

Comments

@dblock
Copy link
Collaborator

dblock commented Jan 27, 2017

The change in #133 was backwards compatible, but we may want a major version change that supports only promises and just using:

Promise.resolve(handlerResult).then(res.send).catch(handleError);

We can also remove the return false functionality and make either returning a Promise or calling the callback required in order to send the response (or just call response.send() explicitly).

@ajcrites
Copy link
Collaborator

ajcrites commented Feb 9, 2017

@dblock do we still want to support callbacks as well or can we purely support promises? This will also apply to pre/post.

@dblock
Copy link
Collaborator Author

dblock commented Feb 9, 2017

I think a deprecation message should happen first, then a major version bump and only supporting promises with good documentation is 👍 for me.

@ajcrites
Copy link
Collaborator

ajcrites commented Feb 9, 2017

Do we want to have a separate issue for actually implementing the changes and keep this simply for adding a deprecation message and updating the documentation?

@dblock
Copy link
Collaborator Author

dblock commented Feb 9, 2017

We want to have some pull requests :)

@dblock
Copy link
Collaborator Author

dblock commented Feb 13, 2017

#167

@ajcrites
Copy link
Collaborator

Can this issue be closed?

@dblock
Copy link
Collaborator Author

dblock commented Feb 17, 2017

Closed via #167.

Also @ajcrites you have committer access don't you. Just do what you think is right and we can argue about it later ;)

@dblock dblock closed this as completed Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants