Allow declarations that start with a multiline comment #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The semi-suppressor is a little too aggressive: if it sees something
like:
```
class Foo {
let property1: String
/* visible for testing */ var property2: String
}
```
It will suppress the newlines before `property2` and cause compilation
to fail. If the comment were on its own line, it would be fine, because
there's still another semi in the way.
The best way to fix this seems to be to allow multiline comments
themselves to count as separators.
alex-pinkus
force-pushed
the
declarations-multiline-comment
branch
2 times, most recently
from
b36d7ec to
74047c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The semi-suppressor is a little too aggressive: if it sees something
like:
It will suppress the newlines before
property2and cause compilationto fail. If the comment were on its own line, it would be fine, because
there's still another semi in the way.
The best way to fix this seems to be to allow multiline comments
themselves to count as separators.