Disallow different characters after certain operators #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all the operators in `scanner.c` are the same. In some cases, the operators should be ignored if the character after them potentially lets them be a custom operator themselves. In other cases, the operator should be ignored if it's followed by alphanumeric characters (since that would make it an identifier). We solve this by adding a new list for the "illegal terminators" and checking against those. This has the bonus of letting us add two new semi suppressors: 1. `as`, the bare keyword, now that we aren't fooled by having it at the start of a word 2. `+` and `-`, but only when followed by whitespace - when there's no whitespace between the operator and the subsequent token, but there _is_ whitespace before it, Swift treats it as a prefix operator. We just have to check the trailing whitespace here because we're just concerned about semi suppression.
The test runner script was always forking, even if it only had one iteration it needed to run. Instead, we can fork only if we're running everything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all the operators in
scanner.care the same. In some cases, theoperators should be ignored if the character after them potentially lets
them be a custom operator themselves. In other cases, the operator
should be ignored if it's followed by alphanumeric characters (since
that would make it an identifier).
We solve this by adding a new list for the "illegal terminators" and
checking against those. This has the bonus of letting us add two new
semi suppressors:
as, the bare keyword, now that we aren't fooled by having it at thestart of a word
+and-, but only when followed by whitespace - when there's nowhitespace between the operator and the subsequent token, but there is
whitespace before it, Swift treats it as a prefix operator. We just have
to check the trailing whitespace here because we're just concerned about
semi suppression.