Allow protocol composition types everywhere #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The grammar suggests that protocol composition types are only allowed "when specifying a type in type annotations, in generic parameter clauses, and in generic where clauses." The corpus of valid code seems to imply otherwise. Instead, we just allow these everywhere, and resolve ambiguity the same way the compiler appears to by giving them right precedence. Fixes #46 Also bundled the one-liner fix for #50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grammar suggests that protocol composition types are only allowed "when
specifying a type in type annotations, in generic parameter clauses, and in
generic where clauses." The corpus of valid code seems to imply
otherwise. Instead, we just allow these everywhere, and resolve
ambiguity the same way the compiler appears to by giving them right
precedence.
Fixes #46
Also bundled the one-liner fix for #50