Manually inline _locally_permitted_modifiers
#130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See semgrep/ocaml-tree-sitter-semgrep#286 When generating a simplified grammar, the `ocaml-tree-sitter` code generator forces all hidden nodes to be visible. It appears that hidden nodes automatically get marked as `inline`, and that without that auto-inlining, the `_locally_permitted_modifiers` rule causes a conflict. Rather than making the semgrep folks work around their conflict, we just check the `inline` declaration into the grammar itself so that it sticks around in the simplified grammar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See semgrep/ocaml-tree-sitter-semgrep#286
When generating a simplified grammar, the
ocaml-tree-sittercode generator forces all hidden nodes to be visible. It appears that hidden nodes automatically get marked asinline, and that without that auto-inlining, the_locally_permitted_modifiersrule causes a conflict.Rather than making the semgrep folks work around their conflict, we just check the
inlinedeclaration into the grammar itself so that it sticks around in the simplified grammar.