Workflow run fails when triggered by an issue_comment event

[andylolz]

My workflow looks like this:

name: This fails
on:
  issue_comment:
    types:
      - created
jobs:
  mark-as-updated:
    steps:
      - uses: alex-page/[email protected]
        with:
          project: Project name
          column: Column name
          repo-token: ${{ secrets.TOKEN }}

It fails with the following error message:

Error: Cannot read property 'projects' of undefined

If I instead trigger it using e.g.:

on:
  issues:
    types:
      - opened

…it works fine.

I’m not exactly sure, but I wonder if the problem is this line:

github-project-automation-plus/src/generate-project-query.js

Line 11 in 8b1f153

... on ${eventName === 'issues' ? 'Issue' : 'PullRequest'} {

[MrDogeBro]

Same issue here but I dont know if thats the line that is causing the problem.

[andylolz]

I thought it was that line because the event name in this case is issue_comment, but that line means it’s treated like a pull request event.

Maybe something like this?

... on ${eventName.startsWith('issue') ? 'Issue' : 'PullRequest'} { 

(Though I haven’t looked into it, and I’m guessing a bit here.)

[alex-page]

Happy to accept a pull request. That definitely looks like it would be a problem with eventName.

[MrDogeBro]

I have done a little testing and it is something within that function. Just gotta do some more testing to figure out what exactly is the problem.

[MrDogeBro]

I thought it was that line because the event name in this case is issue_comment, but that line means it’s treated like a pull request event.

Maybe something like this?

... on ${eventName.startsWith('issue') ? 'Issue' : 'PullRequest'} { 

(Though I haven’t looked into it, and I’m guessing a bit here.)

Ahh I see -- that would probably make sense. I'll try that solution and see what happens.

[MrDogeBro]

Ok I have just tested and that solution seems to work! I will make a PR with the changes!