Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a troubleshooting guide #38

Closed
pandafy opened this issue May 11, 2020 · 13 comments · Fixed by #43
Closed

Add a troubleshooting guide #38

pandafy opened this issue May 11, 2020 · 13 comments · Fixed by #43
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@pandafy
Copy link
Contributor

pandafy commented May 11, 2020

Add which permissions are needed to be selected while creating personal access token.

@alex-page
Copy link
Owner

Hey @pandafy great idea. Did you want to contribute some documentation in the README.md?

@alex-page alex-page added good first issue Good for newcomers help wanted Extra attention is needed labels May 12, 2020
@pandafy
Copy link
Contributor Author

pandafy commented May 12, 2020

I would love to but I don't have any idea which permissions are needed to be selected.
We can add troubleshooting guides for :

  • Bad credentials
  • Can't read repository null (I didn't gave access to privare repository, but it solved after giving this access)
  • Access to public repository is must to maintain project board.

@alex-page
Copy link
Owner

alex-page commented May 12, 2020

These are the project board scenarios I know. I need to figure out the exact different permissions for each. I have put down some assumptions for permissions.

repo Full control of private repositories

  • Public repository and project board
  • Private repository and project board

admin:org Full control of orgs and teams, read and write org projects

  • Organisation project board
  • Organisation public repository with project board
  • Organisation private project board
  • Organisation with private repository and project board

? Not sure on this one

  • User account has a project board
  • User account has a private project board

Where to add secrets? organisation or repository.

@pandafy
Copy link
Contributor Author

pandafy commented May 12, 2020

repo Full control of private repositories

  • Public repository and project board
  • Private repository and project board

I didn't need to give full control of private repositories for a public repository I used this with. We should encourage users to follow concept of Least Privilege Permissions.

@alex-page
Copy link
Owner

Definitely agree on least permissions. I think for next steps we need to do a manual test with each scenario and minimal permissions to make sure they are correct.

I'm happy to do it but I have some other priorities this week.

@alex-page
Copy link
Owner

alex-page commented May 16, 2020

Another state to document was found by @canarro #39 (comment)

@pandafy
Copy link
Contributor Author

pandafy commented May 16, 2020

I'll will try to do manual testing of required permissions over the weekend. 😄

@pandafy
Copy link
Contributor Author

pandafy commented May 16, 2020

There is one more thing which should be added in the documentation, Contributing Guidelines. @alex-page I don't think you ever expected people to contribute to your work. 😆
#40

@rodrigondec
Copy link

@alex-page

It will be good to document this too: actions/toolkit#465 (comment).

from #39

@alex-page
Copy link
Owner

I feel like I should handle an error if the secret is an empty string? What do you think @rodrigondec ?

@rodrigondec
Copy link

rodrigondec commented May 19, 2020

I feel like I should handle an error if the secret is an empty string? What do you think @rodrigondec ?

I think it is the best case. And add to the docs about this limitation (of the github itself) with references.

@alex-page will you reopen the #39 and make this modification? @conarro just commented on the issue about hist problem. Maybe it's the same?

I can help with the docs 😁

@alex-page
Copy link
Owner

alex-page commented May 19, 2020

Yeah i will re-open #39 and we can resolve it with this guide. That would be great @rodrigondec.

@pandafy if you have anything you can put up in a draft PR that would be awesome. Otherwise happy to start a PR we can collaborate on together.

@pandafy
Copy link
Contributor Author

pandafy commented May 19, 2020

Apologies @alex-page , I have been busy lately. Please go ahead to create a PR. I will try to give my inputs along the way. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants