Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem text color when using black color alarm with normal theme and dark theme #505

Closed
oijkn opened this issue Dec 2, 2021 · 1 comment · Fixed by #506
Closed

Problem text color when using black color alarm with normal theme and dark theme #505

oijkn opened this issue Dec 2, 2021 · 1 comment · Fixed by #506
Labels
bug Something isn't working

Comments

@oijkn
Copy link

oijkn commented Dec 2, 2021

Issue Summary
If I set color alarm to black with normal theme, the text is not readable.
If I set color alarm to white with dark theme, the text is not readable.

Environment

  • OS: CentOS 7

  • API version: 8.6.4

  • Deployment: Docker

  • Database: Postgres

  • Server config:
    Auth enabled: Yes
    Auth provider: Keycloack
    Customer views: Yes

  • web UI version: 8.6.1

  • CLI version: 8.6.4

To Reproduce
Steps to reproduce the behavior:

  1. Set color alarm to black
  2. Click on alerts menu

Expected behavior
A white text over black color

Screenshots
image
image

@satterly
Copy link
Member

satterly commented Dec 2, 2021

The previous version (in AngularJS) had the following ...

    <tr ng-repeat="alert in alerts | filter:filter | orderBy:predicate:reverse | limitTo:alertLimit"
        ng-style="{ 'color':  colors.severity[alert.severity] == 'black' ? 'white' : colors.text, 'background-color': (bulkAlerts.indexOf(alert.id) > -1) ? colors.highlight : colors.severity[alert.severity] || 'silver' }"
        ng-click="click($event,alert);">

https://github.com/alerta/angular-alerta-webui/blob/4d0b6327cd3bcde44df6a3db9ad961a92e080748/app/partials/alert-list.html#L48-L50

@satterly satterly added the bug Something isn't working label Dec 2, 2021
@satterly satterly moved this to ✅ Done in Alerta Project Dec 2, 2021
@oijkn oijkn changed the title Problem text color when using black color alarm with normal theme Problem text color when using black color alarm with normal theme and dark theme Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants