Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Run pytest, Flake8 and mypy on GitHub Actions on Ubuntu 20.04, 22.04, Debian and macOS #86

Open
hoh opened this issue Aug 17, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@hoh
Copy link
Member

hoh commented Aug 17, 2022

Problem

We would like to support many user systems with aleph-client, including:

  • Ubuntu 20.04
  • Ubuntu 22.04
  • Debian Bullseye
  • macOS 12 Monterey
  • Windows 10

While most of the code is portable, some dependencies are compiled differently for different systems.

Tests currently run only on Ubuntu 20.04 via a Docker image, as defined in https://github.com/aleph-im/aleph-client/blob/master/.github/workflows/test-pytest.yml

This gives us low confidence on whether aleph-client works on these platforms, and we have no idea if a commit breaks it.

Proposal

Add GitHub Actions workflows that run pytest with flake8 and check for coverage. Also check types using mypy.

https://pypi.org/project/flake8/
https://pypi.org/project/mypy/
https://pypi.org/project/pytest-cov/

@hoh hoh added the enhancement New feature or request label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant