Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

objCollidMap1D does not update tileabove #271

Open
iami19 opened this issue Mar 17, 2024 · 4 comments
Open

objCollidMap1D does not update tileabove #271

iami19 opened this issue Mar 17, 2024 · 4 comments

Comments

@iami19
Copy link

iami19 commented Mar 17, 2024

objCollidMap1D does not update tileabove.
tilestand and tilebprop are updated correctly.
Same issue with objCollidMap, I guess.

@joefuzz
Copy link

joefuzz commented May 6, 2024

I noticed this behavior, too. When testing this with the snes-examples/objects/mapandobjects/ code, I found that the marioobj->tilestand property updated with the tile attribute (T_SOLID in this case), but the tileabove, status, tilesprop, and tilebprop don't appear to update. I looked into pvsneslib/source/objects.asm to see if I could see if I was missing something. That's when I noticed that none of those values ever seem to be written, but there are several instances where a value is written to tilestand.

I'm still a bit of a beginner with ASM so it might take a bit of poking for me to understand it all. Since collision works on the y-axis, I assume it's possible to get the tile information, but it'll take a lot of trial and error before I figure out where.

@alekmaul
Copy link
Owner

alekmaul commented May 7, 2024

but, as it is a 1D map, you are not "on top of" a tile, why do you want that we update "tileabove". You don't have the information in tilestand?

@joefuzz
Copy link

joefuzz commented May 7, 2024

That's a fair point. However, I made a mistake in my post by failing to mention that I also observed this behavior with the objCollidMap function. The example project I mentioned, mapandobjects uses that one. Sorry for the confusion.

@alekmaul
Copy link
Owner

SO, do you still want something in this property for the objCollidMap1D function? we can discuss about something handle by the property with objCollidMap1D function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants