Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - The custom gutter icons stopped showing #411

Closed
lastmartianlaboratory opened this issue Mar 13, 2021 · 4 comments
Closed

[BUG] - The custom gutter icons stopped showing #411

lastmartianlaboratory opened this issue Mar 13, 2021 · 4 comments
Labels
bug caused by vscode The issue was caused by a VS Code update

Comments

@lastmartianlaboratory
Copy link

Environment/version

  • Extension version: 13.0.3
  • VSCode version: 1.54.1 and up
  • OS version: macOS Big Sur, WIndows 10

Steps to reproduce

  1. Set bookmarks.gutterIconPath to a valid image path
  2. Bookmarks become invisible

Custom icons stopped showing since the most recent updates (VSCode 1.54.1, 1.54.2)
Default bookmark icon shows Ok.

@alefragnani
Copy link
Owner

Hi @lastmartianlaboratory ,

It seems the latest VS Code release now blocks loading resources from locations other than "VS Code controlled" ones. More info here microsoft/vscode#118623.

I'm not a fan of copying the new icon to some controlled location, but it seems to be the only solution right now.

Hope this helps

@alefragnani alefragnani added the caused by vscode The issue was caused by a VS Code update label Mar 13, 2021
@lastmartianlaboratory
Copy link
Author

Thank you! That did the trick 👍

And if that's how VSCode handles resources now the bookmarks.gutterIconPath should probably have some sort of a note or removed altogether.

@alefragnani
Copy link
Owner

Yep, I'll take a look on alternatives.

@alefragnani
Copy link
Owner

alefragnani commented Jul 3, 2021

I'm closing this issue in favor of #445, where you will be able to customize the Bookmark's icon appearance (fill and border colors), but not the icon itself.

I can leave the current gutterIconPath setting there, noted as deprecated, if you still use it. Otherwise you could simply move to the new settings when available.

Thank you for your understanding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug caused by vscode The issue was caused by a VS Code update
Projects
None yet
Development

No branches or pull requests

2 participants