Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the TreeView to use the new "Activity Bar" API #109

Closed
ashmckenzie opened this issue May 2, 2018 · 5 comments
Closed

Move the TreeView to use the new "Activity Bar" API #109

ashmckenzie opened this issue May 2, 2018 · 5 comments
Labels
depends on Depends on issues from VS Code enhancement side bar
Milestone

Comments

@ashmckenzie
Copy link

It would be great if it were possible to have an icon on the side bar the toggles the bookmark list view!

e.g.

srcgdkgdk-eegitlab gitlabeelibgitlabgeolog_cursordaemon rb gdk-ee workspace 2018-05-02 16-35-25 1

@alefragnani
Copy link
Owner

Hi @ashmckenzie ,

I remember that in the beginning, this is how the extensions would work. But for some reason, it was changed to add a new Panel in Explorer.

Looking for news about it, I found this issue in VS Code repo, and doing a small test, I was able to move the Bookmarks panel from the Explorer
view to its own view. So, it appear it is returning 😀 .

But, I still need this other issue, which is planned only for May 2018. I see the pros and cons of both views, and I would really like to be able to choose which one to use.

Hope this helps

@alefragnani alefragnani added enhancement depends on Depends on issues from VS Code side bar labels May 2, 2018
@Otiel
Copy link

Otiel commented May 4, 2018

For reference: https://code.visualstudio.com/updates/v1_23#_contributions-to-the-activity-bar

@rbenson
Copy link

rbenson commented May 7, 2018

I would be in favor of an activity bar add vs explorer pane, largely to keep explorer more clean, and I tend to use bookmark-list over the pane

@alefragnani
Copy link
Owner

It appears (based on reactions) that maybe there is need to be able to choose between a Panel in Explorer View and an Bookmarks View (exclusive), am I right? 😄

So, let's vote?

👍 - Completely move to a new Bookmarks View
👎 - Create a setting to choose between view (wait for microsoft/vscode#48704)

@pakLebah
Copy link

I think it'd be better to make it as an option so everyone will be able to choose whichever s/he prefers. Everybody wins. 😊

@alefragnani alefragnani modified the milestone: 9.0 May 20, 2018
@alefragnani alefragnani added this to the 9.0 milestone Jun 10, 2018
@alefragnani alefragnani changed the title Bookmark list as an icon on the side? Move the TreeView to use the new "Activity Bar" API Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depends on Depends on issues from VS Code enhancement side bar
Projects
None yet
Development

No branches or pull requests

5 participants