Default to true for "bookmarks.navigateThroughAllFiles"

[hadrien-psydk]

Hello,

Thank you for your excellent extension. Bookmarking is a feature I was missing in VS Code.

I am opening a feature request to suggest setting "bookmarks.navigateThroughAllFiles" to true by default. I have no problem if you disagree with it, but I have been using Notepad++, Sublime Text and Visual Studio (the full IDE) and it seems they all default to cross document navigation for bookmarks. I think it would be less surprising for a new user to get cross document navigation too by default in VS Code + your extension. I spent myself some time finding the right setting.

Best Regards,

[alefragnani]

Hi @hadrien-psydk ,

Thanks, I'm glad you like!

I understand you, and I'm starting to think that yes, it should be true by default. I have closed another issue (#21) in the past, but by now, maybe I could change that.

Thanks for remembering that suggestion

[virzen]

I second this, I thought it's a bug and only through this issue I've found the settings to enable it. For me jumping through all files was the expected behavior from the very beginning.

[nikitavoloboev]

I disagree with it being a default behavior. But it's great to have a setting for it.

[ghost]

I expected also this to be the default and I could find that info only by coming here. I would suggest to update the doc as a minimum.

[SergeyBeloglazov]

I'm using VSC about 1.5 year and everything was fine until now. I was so close to removing this extension as broken....
I used Notepad++ and other IDEs for many years, and have never ever seen if bookmark navigation move me to another file.
I think, more predictable behavior for the new user is navigation only inside a current file.
For bookmarking files I use a "favorite" extension.
You may leave the default behavior as it's for now, but please, write it clearly in the features, that jumping is performing through all files by default.
Thank your for the extension!

[alefragnani]

Hi @SergeyBeloglazov ,

I"m coding for many years too, with a lot of different Editors and IDEs, and it's funny to think that I never liked to use the unlimited bookmarks feature they provided. I loved Delphi approach, with only 10 bookmarks per file, individually defined with its own keyboard shortcuts. In the end, I used the same file based concept here.

But, since the beginning, some people asked to have a workspace based navigation, and I added. It was a new feature, and I decided to leave false by default. Then, a lot of people complained because didn't noticed the setting. Make it true by default considered the amount of issues opened about it.

Deciding default value for setting is always a pain. Leave as it is, and people don't see the new feature. Use the new value, and current users may dislike.

But I understand your point, the docs can be improved to make it clear, and will be,

Hope this helps

[SergeyBeloglazov]

But I understand your point, the docs can be improved to make it clear, and will be,

Thank You!
The first thing I did - went to description page, didn't see anything about jumping inside one file or though all the workspace.
I decided at first it works only the one way, and it doesn't suit for me. Later found an option.
Anyway the option is great, everybody can be happy! :)