Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky bookmark #10

Closed
ghost opened this issue Jan 10, 2016 · 5 comments · May be fixed by jhamot/vscode-bookmarks#1
Closed

Sticky bookmark #10

ghost opened this issue Jan 10, 2016 · 5 comments · May be fixed by jhamot/vscode-bookmarks#1
Milestone

Comments

@ghost
Copy link

ghost commented Jan 10, 2016

Would be a nice feature to be able to make the bookmarks sticky to the original line of code when the bookmark was first added. After a while of coding all my bookmarks make no sense anymore.

@gCastl
Copy link
Contributor

gCastl commented Feb 28, 2016

This feature it also a must have to me. I would like to know if you started to work on it because i worked on it in my fork. You can take a look or i can make a PR.

@alefragnani
Copy link
Owner

I didn't started yet. I priorized other features and right now I'm working on #8 . But feel free to work on it and send a PR. I will be glad to merge it when it's done 😄

I was wondering how to manage the line changes, and your idea is interesting. I didn't test it but I looked your code. It may have two issues when the lineCount doesn't change:

  • Pasting text (same line count) over an area that already contains a Bookmark (which should remove the Bookmark)
  • Move lines should move the Bookmark.

When the issue was posted, I thought to look at VSCode itself, and see how it handles Breakpoints, at least to have an idea.

Thank you for your cooperation. I will be waiting for you PR 👍 .

@alefragnani alefragnani removed their assignment Feb 28, 2016
@gCastl
Copy link
Contributor

gCastl commented Mar 1, 2016

Great. I continue to work on it then. Thanks for the (little 😄) review.

@alefragnani
Copy link
Owner

Thank you for helping with this 👍

@Nimzozo
Copy link

Nimzozo commented Mar 3, 2016

I have this issue too. After a lot of changes, my bookmarks are not on the good lines of code I placed them initially. (If I add 5 lines before the bookmark, it is then 5 lines too early.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants