kram - build - cmake fixes

alecazam · Sep 15, 2024 · d2030cc · d2030cc
1 parent 16170b3
commit d2030cc
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/pre-release.yml b/.github/workflows/pre-release.yml
@@ -21,7 +21,7 @@ jobs:
         uses: lukka/get-cmake@latest
 
       - name: Check out code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Build and install to bin/
         run: ./scripts/cibuild.sh ${{ matrix.os }}

diff --git a/libkram/CMakeLists.txt b/libkram/CMakeLists.txt
@@ -214,7 +214,7 @@ if (BUILD_MAC)
         XCODE_ATTRIBUTE_ONLY_ACTIVE_ARCH "NO"
     )
 
-    # Enable all warnings, and also enable f16c sims op
+    # Enable all warnings, and also enable f16c sims op (only x64 though)
     target_compile_options(${myTargetLib} PRIVATE -W -Wall -mf16c)
 
     # this is already done by pch for libkram, but other projects need the force include inherited

diff --git a/libkram/compressonator/bc6h/bc6h_encode.cpp b/libkram/compressonator/bc6h/bc6h_encode.cpp
@@ -597,7 +597,7 @@ bool BC6HBlockEncoder::TransformEndPoints(AMD_BC6H_Format &BC6H_data, int iEndPo
 
 void BC6HBlockEncoder::SaveCompressedBlockData( AMD_BC6H_Format &BC6H_data,
         int oEndPoints[MAX_SUBSETS][MAX_END_POINTS][MAX_DIMENSION_BIG],
-        int iIndices[2][MAX_SUBSET_SIZE],
+        int iIndices[MAX_SUBSETS][MAX_SUBSET_SIZE], // did harcode 2 = BC6H_MAX_SUBSET_SIZE, but not what is passed
         int max_subsets,
         int mode) {
     BC6H_data.m_mode    = (unsigned short)mode;