Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Object Oriented Programming concepts #21

Closed
alec-kr opened this issue Sep 22, 2022 · 0 comments · Fixed by #23
Closed

Implement Object Oriented Programming concepts #21

alec-kr opened this issue Sep 22, 2022 · 0 comments · Fixed by #23
Labels
enhancement New feature or request

Comments

@alec-kr
Copy link
Owner

alec-kr commented Sep 22, 2022

Problem

Currently, we have no object-oriented programming (OOP) principles employed in the project. This will make it difficult when trying to implement new features later during the development of the package. There will also be increased complexity as we continue to develop the project without any OOP concepts.

Solution

Classes should be implemented in each of the function files.
Example: race_schedule.py can contain a class RaceSchedule, that accepts JSON data and processes it.

This change will potentially reduce the difficulty during debugging. The readability of the code will also be increased, thus making it easier for new developers to begin contributing.

@alec-kr alec-kr added the enhancement New feature or request label Sep 22, 2022
@alec-kr alec-kr changed the title Implement Object Oriented Programming Implement Object Oriented Programming concepts Sep 22, 2022
@alec-kr alec-kr moved this to In Progress in F1PyStats Development Sep 22, 2022
@alec-kr alec-kr linked a pull request Sep 24, 2022 that will close this issue
Repository owner moved this from In Progress to Done in F1PyStats Development Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

1 participant