Prepare 2.3.1 #378
Merged
Prepare 2.3.1 #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #378 +/- ##
=======================================
Coverage 98.83% 98.83%
=======================================
Files 28 28
Lines 1895 1895
Branches 407 407
=======================================
Hits 1873 1873
Misses 2 2
Partials 20 20 ☔ View full report in Codecov by Sentry. |
orbeckst
requested changes
Jul 7, 2024
There was a problem hiding this comment.
Not sure why rst isn't working, I normally run twine check and it tells me what's wrong. In any case, markdown is ok, too (even though I generally consider it a poor replacement for reST ... but README is fine).
However, you need to fix-up a whole bunch places.
- MANIFEST.in
- setup.py
- CHANGES:
- add your name to 2.3.1
- add the release date
Maybe other places, check with git grep README.
setup.py
Outdated
| @@ -41,7 +41,7 @@ | |||
| packages=find_packages("src"), | |||
| package_dir={"": "src"}, | |||
| license="BSD", | |||
| long_description=open("README.rst").read(), | |||
| long_description=open("README.md").read(), | |||
| long_description_content_type="text/x-rst", | |||
There was a problem hiding this comment.
Change the content description.
orbeckst
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the
rstreadme cannot be used as long description, changed this tomarkdownfile and it seems to work.Build and tested on pypi testing channel