Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adopt SPEC 0 instead of NEP 29 #370

Merged
merged 1 commit into from
May 29, 2024
Merged

adopt SPEC 0 instead of NEP 29 #370

merged 1 commit into from
May 29, 2024

Conversation

orbeckst
Copy link
Member

@orbeckst
adopt SPEC 0 instead of NEP 29
bd650af 
- fix #369
- once this is fixed, we can update the JOSS paper draft PR #328 to only mention
  SPEC 0
@orbeckst orbeckst requested a review from xiki-tempula May 28, 2024 22:41
@codecov Codecov
Copy link

codecov bot commented May 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.83%. Comparing base (6f403f4) to head (bd650af).
Report is 9 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #370   +/-   ##
=======================================
  Coverage   98.83%   98.83%           
=======================================
  Files          28       28           
  Lines        1895     1895           
  Branches      407      407           
=======================================
  Hits         1873     1873           
  Misses          2        2           
  Partials       20       20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xiki-tempula
xiki-tempula approved these changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@xiki-tempula xiki-tempula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@orbeckst orbeckst merged commit 584588c into master May 29, 2024
11 checks passed
@orbeckst orbeckst deleted the spec0 branch May 29, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiki-tempula xiki-tempula xiki-tempula approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

switch from NEP29 to SPEC0
2 participants
@orbeckst @xiki-tempula