Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using loguru #301

Closed
xiki-tempula opened this issue Mar 18, 2023 · 3 comments · Fixed by #303
Closed

Using loguru #301

xiki-tempula opened this issue Mar 18, 2023 · 3 comments · Fixed by #303

Comments

@xiki-tempula
Copy link
Collaborator

I have been using loguru for a year now and I really like it. I think this could make the logging much easier for us.

There is the user aspect.
One could just do logger.add("alchemlyb.log") to save the log to a file.

Also one doesn't need to initialise a logger and the function name would just be printed to the start of the line.
For debugging purpose, the loguru would also print all the public variables to the log.

@orbeckst
Copy link
Member

Does it work with the Python logger? What I find useful is that my application code can just collect all logging from all libraries that it imports. It becomes a bit awkward when not all libraries respect my choices.

@orbeckst
Copy link
Member

@orbeckst
Copy link
Member

orbeckst commented Apr 1, 2023

If you want to change over then I am ok with it.

I'd just like to have some minimal documentation that shows users how to make use of the logging facility from their own scripts.

@xiki-tempula xiki-tempula linked a pull request Apr 2, 2023 that will close this issue
@xiki-tempula xiki-tempula mentioned this issue Jun 1, 2023
@xiki-tempula xiki-tempula added this to the 2.1.0 milestone Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants