Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soul campfire should be made with a fire starter #213

Closed
freyebeans opened this issue Dec 15, 2021 · 3 comments
Closed

soul campfire should be made with a fire starter #213

freyebeans opened this issue Dec 15, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@freyebeans
Copy link

the soul campfire should also be made with the fire starter and possibly also have compatibility with the ender campfire from the endergetic expansion

@Gunner76th
Copy link

Gunner76th commented Feb 22, 2022

46682d0

Looking a the note for this commit it would appear that the addition of the config option to enable/disable the recipe for each of the campfires was overlooked.

image

This has broken crafting recipes for https://www.curseforge.com/minecraft/modpacks/engineers-life-2 in which we were using the soul camp fire as a crafting ingredient for several other items. Will the config option to enable/disable the removal of the crafting recipe for the camp fire and soul camp fire be added into the next update since it was missed in 4.3.0?

@Gunner76th
Copy link

To clarify, some mods as well as modpacks depend on the vanilla campfire or soul campfire recipe for the crafting of other items. by removing those recipes without either the option to add them back in through the config, or leaving the recipe in game but making the crafted item not placeable has caused those mods and modpacks to become broken. Please consider either adding a config option to restore the recipe if the config is set to false for the campfires to be creatable with the fire starter, or have it leave the recipe in game but change it to a non-placeable item.

@alcatrazEscapee
Copy link
Owner

the addition of the config option to enable/disable the recipe for each of the campfires was overlooked.

No, it wasn't. Modification of recipes is done via datapacks, I'm not going to add a config option for something that's already completely possible to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants