-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove collisions between box colliders and sphere colliders #202
Open
SebastianHolm
wants to merge
11
commits into
dev
Choose a base branch
from
box-sphere-collision
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karloq
approved these changes
Apr 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be working fine!
SebastianHolm
added
low-priority
This issue will not be prioritised
waiting
This is waiting on another issue
labels
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
low-priority
This issue will not be prioritised
performance
Related to the performance of the simulation
waiting
This is waiting on another issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue I posted while experimenting with layer collision matrix. I found that all the animals box colliders react to all sphere colliders. This was the majority of all collisions that occurred which seemed inefficient since they then had to go through all tag checks.
This PR adds another object to each animal with the purpose of being the trigger for the sphere collider. The box collider could then be unchecked as a trigger in the matrix for the sphere colliders making it only react to things of interest.
Unfortunately to make this work the new game object needed a new collider and rigidbody, making the total collider count of each animal go up to 3. I was hesitant to make this PR push but I guess you guys can help me decide if this PR is necessary.
#196