Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A question about some loss functions in the paper #106

Open
LinglanZhao opened this issue Jul 30, 2019 · 0 comments
Open

A question about some loss functions in the paper #106

LinglanZhao opened this issue Jul 30, 2019 · 0 comments

Comments

@LinglanZhao
Copy link

I have read your paper 'GANimation: Anatomically-aware Facial Animation from a Single Image'. However, I am confused about the definitions of some of the loss functions.

  1. For the Image Adversarial Loss defined in 4.2, I think that a negative sign should be put in front of it to in line with the similar loss defined in 'StarGAN'.
    Image Adversarial Loss

  2. For the Conditional Expression Loss defined in Eq (3), I think that a negative sign should be put in front of the second term, because the Generator and the Discriminator should perform in an adversarial way instead of cooperation.
    Conditional Expression Loss

If I have made any mistakes, thank you for your corrections. @albertpumarola

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant