fix: only send data if the socket is open #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the read promise resolves without error, but the socket is in the `CLOSING` state. This causes an error to be thrown so only send data if the socket is `OPEN` - if it's `CLOSING` treat it as `CLOSED` and exit the loop.
github-actions bot
pushed a commit
that referenced
this pull request
Aug 10, 2023
## [6.0.2](v6.0.1...v6.0.2) (2023-08-10) ### Bug Fixes * only send data if the socket is open ([#75](#75)) ([f63265e](f63265e))
|
🎉 This PR is included in version 6.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the read promise resolves without error, but the socket is in the
CLOSINGstate.This causes an error to be thrown so only send data if the socket is
OPEN- if it'sCLOSINGtreat it asCLOSEDand exit the loop.Fixes this sort of thing: