fix: add buffer require #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Future versions of webpack will not bundle node internals so we have to `require` them as they won't be globals any more. Weirdly `buffer` was already a dep of this module but wasn't used in the actual source 🤷♂️
achingbrain
force-pushed
the
fix/add-buffer-require
branch
from
f3f3bcc
to
3edada6
Compare
achingbrain
added a commit
to ipfs/js-ipfs-utils
that referenced
this pull request
Jul 2, 2020
Depends on: - [alanshaw/it-to-stream#4](alanshaw/it-to-stream#4)
1 task
Exiting an async iterator in a pipline early causes a `ERR_STREAM_PREMATURE_CLOSE` to be thrown. This should be fixed in a future node release: nodejs/node#23890
alanshaw
approved these changes
Jul 2, 2020
achingbrain
added a commit
to ipfs/js-ipfs-utils
that referenced
this pull request
Jul 9, 2020
* chore: update aegir Depends on: - [alanshaw/it-to-stream#4](alanshaw/it-to-stream#4) * chore: update it-to-stream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future versions of webpack will not bundle node internals so we have to
requirethem as they won't be globals any more.Weirdly
bufferwas already a dep of this module but wasn't used in the actual source 🤷♂️